NNUE search integration: FH% tables, NODE_TYPE refinement, TREEDUMP rewrite

- data.c/chess.h: widen the joint FH% table's late axis 16->17, dedicating
  the new bucket 0 to a whole-node ("will something here fail high at
  all") sample rather than sharing it with the first-leftover-move curve.
  Add an NNUE-eval counterpart table (g_uJointFHThousandths_NNUE) and an
  NNUE counterpart of the beta-side table, selected at runtime based on
  whether NNUE eval is active.
- search.c/searchsup.c: add _RefineNodeTypeGuess, which uses the FH%
  tables (via g_NodeTypeGuessTable) to refine a node's NODE_TYPE guess
  instead of the old heuristic; thread uParentMoveFHEstimate through
  PLY_INFO so a node can see its parent's prediction for the move that
  led to it.
- generate.c: initialize sKillers[2]/[3].uBonus unconditionally (an
  uninitialized-stack read caught by valgrind under LTO; harmless today
  but a real bug).
- dumptree.c/chess.h/GNUmakefile: replace the long-dead DUMP_TREE XML
  tree dump (written for a GUI this project no longer has) with TREEDUMP,
  a flat, path-keyed move/result trace meant to diff against an
  identically-instrumented Stockfish build -- see docs/TREEDUMP_FORMAT.md.
- docs/DEEPER_PRUNING.md: notes on closing the search-efficiency gap vs
  Stockfish.
- crafty_egtb/stockfish_xboard/typhoon_nnue: wrapper scripts so
  match_play.py's Engine class can drive Crafty, Stockfish (via
  PolyGlot), and an NNUE-enabled typhoon the same way it drives HCE
  typhoon.
- tests/lop: rename lop.txt -> lop.ep_; update compare_lop.cpp.
- annotate_pgns: add aggregate_marginsafety.py, dedup_pgn.py,
  fit_lazy_probe.py; update annotate.py/run_nnue_pipeline.py for the NNUE
  training pipeline.
- .gitignore: ignore compile_commands.json (clangd build DB) and
  eval.nnue (a symlink into the untracked head_reference/ comparison
  baseline), neither of which belongs in the repo.

Co-Authored-By: Claude Sonnet 5 <[email protected]>

1 files changed, 10 insertions, 0 deletions

diff --git a/src/generate.c b/src/generate.c
index 569face..cf31891 100644
--- a/src/generate.c
+++ b/src/generate.c
@@ -4747,6 +4747,16 @@ Return value:
     sKillers[1].uBonus |=
         (SORT_THESE_FIRST * (IS_KILLERMATE_MOVE(sKillers[1].mv) != 0));
     sKillers[2].mv.uMove = sKillers[3].mv.uMove = 0;
+    // uBonus must be initialized unconditionally too, matching .mv
+    // above -- at uPly<=1 the "if" below never runs, but the move-
+    // scoring code further down reads both fields unconditionally
+    // (IS_SAME_MOVE(sKillers[2].mv, mv) * sKillers[2].uBonus). Harmless
+    // today (sKillers[2].mv is zeroed, so that match is always false
+    // and 0 * garbage still yields 0), but a real uninitialised-stack
+    // read that valgrind correctly flags -- caught chasing an
+    // unrelated report that turned out to trace back to this exact
+    // stack slot via register/value propagation under LTO.
+    sKillers[2].uBonus = sKillers[3].uBonus = 0;
     if (uPly > 1)
     {
         sKillers[2].mv = ctx->mvKiller[uPly - 2][0];