Eval mobility/pseudo-mobility tweaks; drop unproductive move-ordering experiments.

eval.c: add bishop/rook x-ray pseudo-mobility terms (squares seen past a
directly-attacked higher-value piece), trim pawn-centrality edge penalty
and bishop-pair bonus.

chess.h/dynamic.c/generate.c/search.c/searchsup.c: revert three move-ordering
experiments (recapture bonus, flee-to-safety GOOD_MOVE promotion, ply-2
move-pair bonus) that calibrated with real fail-high signal but never
converted into a measurable node-count or solve-rate win on the curated
suites -- see MOVE_ORDERING_IDEAS.md for the evidence and reasoning behind
each drop. Add MOVE_ORDERING_EVIDENCE_COLLECTION as its own GNUmakefile
flag, independent of PERF_COUNTERS, for any future such harness.

command.c: remove the KING_DEFECT_DUMP-gated evalkingdump command, dead
since the king-safety remine work moved to eval_tune/king_safety_data/.

Co-Authored-By: Claude Sonnet 5 <[email protected]>

1 files changed, 0 insertions, 110 deletions

diff --git a/src/command.c b/src/command.c
index 1902784..b30de2b 100644
--- a/src/command.c
+++ b/src/command.c
@@ -547,108 +547,6 @@ Return value:
 }
 
 
-#ifdef KING_DEFECT_DUMP
-COMMAND(EvalKingDumpCommand)
-/**
-
-Routine description:
-
-    This function implements the 'evalkingdump' engine command, only
-    built under KING_DEFECT_DUMP. Runs a full static eval (same
-    persistent-context pattern as EvalCommand) then prints one
-    space-separated key=value line per side with _EvalKing's raw,
-    per-defect breakdown (chess.h's KING_DEFECT_DUMP_INFO) instead of
-    the single collapsed score -- feeds an offline regression against
-    real mate outcomes. See CLAUDE.md's king-safety discussion.
-
-    Usage:
-
-        evalkingdump
-
-Parameters:
-
-    The COMMAND macro hides four arguments from the input parser:
-
-        CHAR *szInput : the full line of input
-        ULONG argc    : number of argument chunks
-        CHAR *argv[]  : array of ptrs to each argument chunk
-        POSITION *pos : a POSITION pointer to operate on
-
-Return value:
-
-    void
-
-**/
-{
-    static SEARCHER_THREAD_CONTEXT *ctx = NULL;
-    static ULONG uLastSeenDnaGeneration = (ULONG)-1;
-    static const CHAR *szPieceName[KING_RING_NUM_PIECE_TYPES] =
-        { "pawn", "minor", "rook", "queen" };
-    ULONG uColor;
-    ULONG uSlot, uPieceType;
-    KING_DEFECT_DUMP_INFO *p;
-
-    if (NULL == ctx)
-    {
-        ctx = SystemAllocateMemory(sizeof(SEARCHER_THREAD_CONTEXT));
-        if (NULL == ctx)
-        {
-            Trace("Out of memory.\n");
-            return;
-        }
-        InitializeSearcherContext(pos, ctx);
-        uLastSeenDnaGeneration = g_uDnaGeneration;
-    }
-    else if (uLastSeenDnaGeneration != g_uDnaGeneration)
-    {
-        InitializeSearcherContext(pos, ctx);
-        uLastSeenDnaGeneration = g_uDnaGeneration;
-    }
-    else
-    {
-        ReInitializeSearcherContext(pos, ctx);
-    }
-    (void)Eval(ctx, -INFINITY_SCORE, +INFINITY_SCORE, NULL);
-
-    for (uColor = 0; uColor < 2; uColor++)
-    {
-        p = &ctx->sKingDefectDump[uColor];
-        Trace("KINGDEFECTDUMP color=%s", COLOR_NAME(uColor));
-        for (uSlot = 0; uSlot < KING_RING_NUM_SLOTS; uSlot++)
-        {
-            if (!p->fOnBoard[uSlot])
-            {
-                Trace(" sq%u_offboard=1", uSlot);
-                continue;
-            }
-            for (uPieceType = 0; uPieceType < KING_RING_NUM_PIECE_TYPES; uPieceType++)
-            {
-                Trace(" sq%u_atk_%s=%u",
-                      uSlot, szPieceName[uPieceType],
-                      p->fAttackedByPieceType[uSlot][uPieceType]);
-            }
-            Trace(" sq%u_undef=%u sq%u_def=%u sq%u_xray=%u sq%u_flight=%u",
-                  uSlot, p->fAttackedUndefended[uSlot],
-                  uSlot, p->fAttackedDefended[uSlot],
-                  uSlot, p->fXrayedUnattacked[uSlot],
-                  uSlot, p->fEmptyFlight[uSlot]);
-        }
-        Trace(" filestorm=%u filestormopenfile=%u filestormpawn=%u "
-              "queenproximity=%u initloc=%u countertotal=%u "
-              "safetyvalue=%u attackerarmyscaler=%u castled=%u minorsathome=%u "
-              "misscastleshort=%u misscastlelong=%u realsafety=%d\n",
-              p->uFileStormDefects, p->uFileStormOpenFile, p->uFileStormStormingPawn,
-              p->uQueenNearKing,
-              p->uInitialCounterByLocation, p->uCounterTotal,
-              p->uSafetyTableValue, p->uAttackerArmyScaler,
-              p->fCastled, p->uMinorsAtHome,
-              p->fMissingCastleShort, p->fMissingCastleLong,
-              p->iRealSafety);
-    }
-}
-#endif
-
-
 COMMAND(QSearchCommand)
 /**
 
@@ -2579,14 +2477,6 @@ COMMAND_PARSER_ENTRY g_ParserTable[] =
       FALSE,
       FALSE,
       "Run a static eval" },
-#ifdef KING_DEFECT_DUMP
-    { "evalkingdump",
-      EvalKingDumpCommand,
-      FALSE,
-      FALSE,
-      FALSE,
-      "Dump _EvalKing's raw per-defect breakdown for both sides" },
-#endif
     { "evaldna",
       EvalDnaCommand,
       FALSE,