summaryrefslogtreecommitdiff
path: root/histogram.py
diff options
context:
space:
mode:
authorScott <[email protected]>2022-02-02 13:47:36 -0800
committerScott <[email protected]>2022-02-02 13:47:36 -0800
commit7ff2af6fe7bffea90dc4a31c93140c189917c659 (patch)
tree34cb138c3a572037b5bc1d1b52ad9d25a2604ccb /histogram.py
parent6ba90a1f30f1c0cf4df12fcd0c62181f29bc3668 (diff)
Let's be explicit with asserts; there was a bug in histogram
caused by assert foo when foo was an int with valid valid 0.
Diffstat (limited to 'histogram.py')
-rw-r--r--histogram.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/histogram.py b/histogram.py
index d45e93f..cea8b76 100644
--- a/histogram.py
+++ b/histogram.py
@@ -81,7 +81,7 @@ class SimpleHistogram(Generic[T]):
last_bucket_start = bucket[0] # beginning of range
if max_population is None or pop > max_population:
max_population = pop # bucket with max items
- if max_population is None:
+ if len(self.buckets) == 0 or max_population is None:
return txt
max_label_width: Optional[int] = None
@@ -100,9 +100,9 @@ class SimpleHistogram(Generic[T]):
max_label_width = label_width
if start == last_bucket_start:
break
- assert max_label_width
- assert lowest_start
- assert highest_end
+ assert max_label_width is not None
+ assert lowest_start is not None
+ assert highest_end is not None
sigma_label = f'[{label_formatter}..{label_formatter}): ' % (
lowest_start,