From 7ff2af6fe7bffea90dc4a31c93140c189917c659 Mon Sep 17 00:00:00 2001 From: Scott Date: Wed, 2 Feb 2022 13:47:36 -0800 Subject: Let's be explicit with asserts; there was a bug in histogram caused by assert foo when foo was an int with valid valid 0. --- unittest_utils.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'unittest_utils.py') diff --git a/unittest_utils.py b/unittest_utils.py index ba9ca28..b259c6b 100644 --- a/unittest_utils.py +++ b/unittest_utils.py @@ -286,12 +286,12 @@ class RecordStdout(object): def __enter__(self) -> Callable[[], tempfile.SpooledTemporaryFile]: self.recorder = contextlib.redirect_stdout(self.destination) - assert self.recorder + assert self.recorder is not None self.recorder.__enter__() return lambda: self.destination def __exit__(self, *args) -> Optional[bool]: - assert self.recorder + assert self.recorder is not None self.recorder.__exit__(*args) self.destination.seek(0) return None @@ -315,12 +315,12 @@ class RecordStderr(object): def __enter__(self) -> Callable[[], tempfile.SpooledTemporaryFile]: self.recorder = contextlib.redirect_stderr(self.destination) # type: ignore - assert self.recorder + assert self.recorder is not None self.recorder.__enter__() return lambda: self.destination def __exit__(self, *args) -> Optional[bool]: - assert self.recorder + assert self.recorder is not None self.recorder.__exit__(*args) self.destination.seek(0) return None -- cgit v1.3