From 5c212d7639f62fcb936f9d7a0bbe704a9f7b213d Mon Sep 17 00:00:00 2001 From: Scott Gasch Date: Tue, 8 Feb 2022 13:08:52 -0800 Subject: Hook in pylint to the pre-commit hook and start to fix some of its warnings. It seems pickier than flake8 which is probably a good thing. --- acl.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'acl.py') diff --git a/acl.py b/acl.py index a1ff405..cf59d6a 100644 --- a/acl.py +++ b/acl.py @@ -1,5 +1,7 @@ #!/usr/bin/env python3 +"""This module defines various flavors of Access Control Lists.""" + import enum import fnmatch import logging @@ -41,23 +43,23 @@ class SimpleACL(ABC): def __call__(self, x: Any) -> bool: """Returns True if x is allowed, False otherwise.""" - logger.debug(f'SimpleACL checking {x}') + logger.debug('SimpleACL checking %s', x) if self.order_to_check_allow_deny == Order.ALLOW_DENY: logger.debug('Checking allowed first...') if self.check_allowed(x): - logger.debug(f'{x} was allowed explicitly.') + logger.debug('%s was allowed explicitly.', x) return True logger.debug('Checking denied next...') if self.check_denied(x): - logger.debug(f'{x} was denied explicitly.') + logger.debug('%s was denied explicitly.', x) return False elif self.order_to_check_allow_deny == Order.DENY_ALLOW: logger.debug('Checking denied first...') if self.check_denied(x): - logger.debug(f'{x} was denied explicitly.') + logger.debug('%s was denied explicitly.', x) return False if self.check_allowed(x): - logger.debug(f'{x} was allowed explicitly.') + logger.debug('%s was allowed explicitly.', x) return True logger.debug( -- cgit v1.3